Skip to content

[WIP] Experimental ObjectDiffusion v2 (just inbound side changes) for efficient vote retrieval #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Parent: Peras staging ground
wants to merge 43 commits into
base: peras-staging
Choose a base branch
from
Draft

[WIP] Experimental ObjectDiffusion v2 (just inbound side changes) for efficient vote retrieval #1698

wants to merge 43 commits into from

Conversation

@tbagrel1
Copy link
Contributor

Co-authored-by: nbacquey [email protected]

Description

Please include a meaningful description of the PR and link the relevant issues
this PR might resolve.

Also note that:

  • New code should be properly tested (even if it does not add new features).
  • The fix for a regression should include a test that reproduces said regression.

@tbagrel1 tbagrel1 changed the title Peras/experimental-object-diffusion-inbound-v2 [WIP] Experimental ObjectDiffusion v2 (just inbound side changes) for efficient vote retrieval Sep 29, 2025
@nbacquey nbacquey mentioned this pull request Oct 1, 2025
Open
@tbagrel1 tbagrel1 linked an issue Oct 2, 2025 that may be closed by this pull request
Figure out non-trivial inbound logic for votes retrieval tweag/cardano-peras#140
Open
@tbagrel1 tbagrel1 force-pushed the peras/experimental-object-diffusion-inbound-v2 branch 2 times, most recently from 9de5d64 to 443cfc8 Compare October 13, 2025 14:03
tbagrel1 and others added 25 commits October 15, 2025 12:53
@tbagrel1 @nbacquey
Initial commit with copy-pasted TxSubmissionV2 for ObjectDiffusionV2
fb5f0b4 
Co-authored-by: nbacquey <[email protected]>
@tbagrel1 @nbacquey
Some refactor
e8458cb 
Co-authored-by: nbacquey <[email protected]>
@tbagrel1
WIP: further refactor
b225208
@nbacquey @tbagrel1
wipper
511ed4f
@tbagrel1
Finish most refactor on Types.hs
6ee28bf
@tbagrel1
Fix some more errors
94dc009
@tbagrel1
Continue re-organizing decision impl
2a899e9
@tbagrel1
WIP before removing dgsObjectsPending
fed9f0d
@tbagrel1
WIP: cleaning State.hs file
dac65af
@nbacquey @tbagrel1
more work on State.hs
8775a5d
@nbacquey @tbagrel1
clean handleReceivedObjectsImpl
3cd2508
@tbagrel1
First diagram attempt
128b6a1
@tbagrel1
Continue on handleReceivedObjectsImpl
36ab9e9
@nbacquey @tbagrel1
Stabilize State.hs, plumbing in Registry.hs
ffe6cf4
@tbagrel1
Further update state.hs
cd4c6a6
@tbagrel1
Improve state management and diagram
70a793f
@tbagrel1
Update state and diagram following removal of `dgsObjectsLiveMultipli…
553c767 
…cities`
@tbagrel1
Update state management (again)
56ee864
@tbagrel1 @nbacquey
Remove objectsPending field
ffb9f39 
Co-authored-by: nbacquey <[email protected]>
@tbagrel1
Simplify pickObjectsToReq logic
cc30a91
@tbagrel1
clean up code in decision process
2377db9
@tbagrel1
Finalize new decision logic
e1a5987
@tbagrel1
formatting
70feb95
@tbagrel1
Further polishing
b7ef54c
@tbagrel1
Remove useless function
629b1b2
@tbagrel1 tbagrel1 force-pushed the peras/experimental-object-diffusion-inbound-v2 branch from 96b7016 to 8bd6007 Compare October 15, 2025 12:00
@tbagrel1 tbagrel1 changed the base branch from main-pr/object-diffusion to peras-staging October 15, 2025 12:03
@tbagrel1
Copy link
Contributor Author

Using IntersectMBO/ouroboros-network@0db8669

@nbacquey nbacquey force-pushed the peras/experimental-object-diffusion-inbound-v2 branch from d28fe49 to f794d6f Compare October 20, 2025 18:08
@nbacquey nbacquey force-pushed the peras/experimental-object-diffusion-inbound-v2 branch from a459164 to 7fa719c Compare October 23, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agustinmista agustinmista agustinmista left review comments

@nbacquey nbacquey nbacquey left review comments

@nfrisby nfrisby Awaiting requested review from nfrisby nfrisby will be requested when the pull request is marked ready for review nfrisby is a code owner

@jasagredo jasagredo Awaiting requested review from jasagredo jasagredo will be requested when the pull request is marked ready for review jasagredo is a code owner

@amesgen amesgen Awaiting requested review from amesgen amesgen will be requested when the pull request is marked ready for review amesgen is a code owner

@fraser-iohk fraser-iohk Awaiting requested review from fraser-iohk fraser-iohk will be requested when the pull request is marked ready for review fraser-iohk is a code owner

@dnadales dnadales Awaiting requested review from dnadales dnadales will be requested when the pull request is marked ready for review dnadales is a code owner

@geo2a geo2a Awaiting requested review from geo2a geo2a will be requested when the pull request is marked ready for review geo2a is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Figure out non-trivial inbound logic for votes retrieval

3 participants

@tbagrel1 @agustinmista @nbacquey